Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile #1169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Driver-C
Copy link

@Driver-C Driver-C commented Aug 8, 2024

I have already tested it

evolve

@yarukishi
Copy link
Contributor

Is this meaningfully different from executing npm run serve and accessing http://localhost:4040?

@Driver-C
Copy link
Author

Is this meaningfully different from executing npm run serve and accessing http://localhost:4040?

If only running locally, it's the same as npm run serve. Container images provide a way to run the evolve service in any environment, users can run the evolve service in their NAS device's docker, or run the evolve service in a Kubernetes cluster. Of course, this feature is not necessary for this project. If the project maintenance team is willing to try to accept container-related engineering features, I can also provide a Helm chart for deploying the evolve service to a Kubernetes cluster in the future. If you think it's unnecessary, then just close this PR

@yarukishi
Copy link
Contributor

yarukishi commented Aug 15, 2024

The only person who can merge anything is Demagorddon, the original and primary developer, so final judgements on tooling upgrades (and all other PRs) are up to him.

@Driver-C
Copy link
Author

The only person who can merge anything is Demagorddon, the original and primary developer, so final judgements on tooling upgrades (and all other PRs) are up to him.

Understood, thanks.

@fredden fredden mentioned this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants